Repository navigation
Changed compare function to Strict Weak Ordering criteria. - #3612
Merged
christophe-murphy merged 1 commit intoOct 23, 2024
Merged
christophe-murphy merged 1 commit into
christophe-murphy merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
christophe-murphy
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current compare function is not "Strict Weak Ordering" since it returns true when both arguments are equal, should be false.
Description
The "Strict Weak Ordering" criteria is necessary because some sort implementations will end in a dead-loop without it.
Additional information about the PR answering following questions:
Fixes: #3378
Changes to Users
None
Checklist