Repository navigation
Fix for lookup offset in opencl and non-column indices - #3650
Merged
edwinsolisf merged 2 commits intoApr 4, 2025
Merged
edwinsolisf merged 2 commits into
edwinsolisf merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…nt dimensions (with fix) Tests added were for lookup with indices being subarrays with non-zero offsets and with indices lying in second, third, and fourth dimension A fix was added for supporting indices that do not lie in the first dimension by making a copy and flattening the indices
3 of 5 tasks
syurkevi
approved these changes
Apr 4, 2025
christophe-murphy
added a commit
that referenced
this pull request
Jun 5, 2025
This was fixed in the opencl back end in PR #3650 but the issue also existed in the oneapi back end and is fixed here.
3 tasks done
christophe-murphy
added a commit
that referenced
this pull request
Jun 13, 2025
This was fixed in the opencl back end in PR #3650 but the issue also existed in the oneapi back end and is fixed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reupload of PR #3611. Check that for more info.
Fixes: #3606
Changes to Users
No action required by the user
Checklist