Repository navigation
windows: check FormatMessage result in getErrorMessage - #3719
Draft
melonakos wants to merge 1 commit into
Draft
melonakos wants to merge 1 commit into
melonakos wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
FormatMessage only writes the output pointer when it succeeds. On failure it returns 0 and leaves lpMsgBuf untouched, so constructing a std::string from it ran strlen over an indeterminate stack value. Initialize the pointer, check FormatMessage's return, and fall back to reporting the raw system error code. Also release the buffer that FORMAT_MESSAGE_ALLOCATE_BUFFER allocates, which previously leaked on every successful call. Fixes #3714 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012SRueobKykUocB1SRdHsEE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormatMessage leaves the output pointer untouched when it fails, and getErrorMessage read it uninitialized and never freed the buffer on success. Check the result, return a fallback with the system error code, and LocalFree the buffer. Fixes #3714.