Remove unsafeCoerce from Data.constant - #73
Merged
dmjio merged 1 commit intoJun 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Replace runtime type-tag dispatch + unsafeCoerce with three direct FFI functions: constant (takes Double, ArrayFire converts internally), constantComplex (preserves imaginary part via af_constant_complex), constantLong / constantULong (64-bit integers without Double rounding). Add tests covering all four functions including precision boundaries (maxBound/minBound for Int and Word64). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace runtime type-tag dispatch + unsafeCoerce with three direct FFI functions: constant (takes Double, ArrayFire converts internally), constantComplex (preserves imaginary part via af_constant_complex), constantLong / constantULong (64-bit integers without Double rounding).
Add tests covering all four functions including precision boundaries (maxBound/minBound for Int and Word64).