packages/react/src/components/presentation/auth/SignUp/v2/BaseSignUp.tsx (1)

561-596: ⚡ Quick win

OAuth error responses from the popup are silently dropped by messageHandler.

When the IDP returns an error (e.g., user denies the consent), the Callback component forwards { code: null, state: null, error: 'access_denied', errorDescription: '…' } via postMessage. The messageHandler only acts when code && state — so the error payload is ignored entirely. The fallback popupMonitor interval does detect error= in the popup URL and closes the popup (line ~630–635), but it calls only logger.error with no handleError/onError propagation, leaving the user with no feedback.

Consider extending the messageHandler to handle the error case:

✨ Suggested extension to handle error postMessages

      const {code, state} = event.data;

+     if (event.data.error) {
+       handleError(new Error(event.data.errorDescription || event.data.error));
+       onError?.(new Error(event.data.errorDescription || event.data.error));
+       popup.close();
+       cleanup();
+       return;
+     }

      if (code && state) {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/react/src/components/presentation/auth/SignUp/v2/BaseSignUp.tsx`
around lines 561 - 596, The message handler currently only processes messages
when both code and state are present, so error payloads are ignored; update the
block that reads const {code, state} = event.data to also detect error and
errorDescription (e.g., const {error, errorDescription} = event.data) and in
that branch call handleError(new Error(errorDescription || error)), invoke
onError?.(new Error(...)), then ensure popup.close() and cleanup() are called
(similar to the success/catch paths). Also extend the popupMonitor fallback
branch that detects error= in the popup URL to call handleError/onError (with a
constructed Error including the error query string) before logging and closing
the popup so error events are propagated consistently.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@packages/react/src/components/presentation/auth/SignUp/v2/BaseSignUp.tsx`:
- Around line 561-596: messageHandler currently processes the postMessage
callback without checking hasProcessedCallback, causing a potential double-call
to onSubmit when popupMonitor has already started handling the same callback;
add a guard at the start of messageHandler to return early if
hasProcessedCallback is true (the same flag set by popupMonitor), and only set
hasProcessedCallback = true immediately before invoking onSubmit in
messageHandler (mirroring popupMonitor) so both paths coordinate and prevent
duplicate onSubmit(payload) calls (refer to messageHandler, popupMonitor,
hasProcessedCallback, and onSubmit).

---

Nitpick comments:
In `@packages/react/src/components/presentation/auth/SignUp/v2/BaseSignUp.tsx`:
- Around line 561-596: The message handler currently only processes messages
when both code and state are present, so error payloads are ignored; update the
block that reads const {code, state} = event.data to also detect error and
errorDescription (e.g., const {error, errorDescription} = event.data) and in
that branch call handleError(new Error(errorDescription || error)), invoke
onError?.(new Error(...)), then ensure popup.close() and cleanup() are called
(similar to the success/catch paths). Also extend the popupMonitor fallback
branch that detects error= in the popup URL to call handleError/onError (with a
constructed Error including the error query string) before logging and closing
the popup so error events are propagated consistently.

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5813aa9c-710f-4296-bfb6-25c50e0d3f45

Reviewing files that changed from the base of the PR and between faf4ab0 and 2e3e9c4.

• packages/react/src/components/auth/Callback/Callback.tsx
• packages/react/src/components/presentation/auth/SignUp/v2/BaseSignUp.tsx
• packages/vue/src/components/auth/Callback.ts