Make AssertJMultipleFailuresError#getMessage render the cause of each failure that has one, so SoftAssertions#fail(String, Throwable) shows cause message: ... and the first stack trace elements of the cause again, as in 3.23.1. Failures without a cause are formatted exactly as before.
The cause was lost because getMessage only used the failure message; Throwables.describeErrors (the #864 fix) was reached only through the SoftAssertionError fallback, which never runs when opentest4j is on the classpath.
SoftAssertionsErrorDescriptionTest did not catch this since it asserted the opentest4j prefix but not the cause; it now asserts the cause too. main is not affected: 452cee7 already renders the cause in MultipleAssertionsError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4125
Make AssertJMultipleFailuresError#getMessage render the cause of each failure that has one, so SoftAssertions#fail(String, Throwable) shows cause message: ... and the first stack trace elements of the cause again, as in 3.23.1. Failures without a cause are formatted exactly as before.
The cause was lost because getMessage only used the failure message; Throwables.describeErrors (the #864 fix) was reached only through the SoftAssertionError fallback, which never runs when opentest4j is on the classpath.
SoftAssertionsErrorDescriptionTest did not catch this since it asserted the opentest4j prefix but not the cause; it now asserts the cause too. main is not affected: 452cee7 already renders the cause in MultipleAssertionsError.