| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
While this PR may solve the issue with numpy.datetime64, it does not go far enough to also fix incorrect conversions of strings to float, e.g. "1E10" becomes 1e+10. See issue #266 Update: I discovered disable_numparse=True which solves that issue ... never mind ... |
Sorry, something went wrong.
|
I argue in #351 that, if you have a type that converts both to int/float and to str, and you explicitly prefer the str representation -- that you should either:
Otherwise, the (much more common) situation -- where you tabulate types that are convertible to int/float -- would be greatly interfered with by a change such as this. Ah; as you found disable_numparse, I recommend we close this issue! |
Sorry, something went wrong.
|
This PR needs test cases to cover and document all new edge cases, and how they are now handled. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The numpy.datetime64[ns] was recognized as float, because numpy.datetime64[ns] is convertible to float. This PR fixes this problem.
Fix #251