Renders GitHub-Flavored Markdown tables in canonical format - #260
Closed
kdeldycke wants to merge 1 commit into
Closed
Renders GitHub-Flavored Markdown tables in canonical format#260kdeldycke wants to merge 1 commit into
kdeldycke wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
kdeldycke
added a commit
to kdeldycke/click-extra
that referenced
this pull request
Apr 4, 2023
Copy link
Copy Markdown
Contributor
Author
|
All tests are passing, this PR is ready to be merged upstream. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This PR has been superseded by #261. |
Sorry, something went wrong.
kdeldycke
added a commit
to kdeldycke/python-tabulate
that referenced
this pull request
Apr 6, 2026
Follow up on astanin#410; Refs astanin#260 and astanin#261.
kdeldycke
added a commit
to kdeldycke/python-tabulate
that referenced
this pull request
Apr 6, 2026
Follow up on astanin#410; Refs astanin#260 and astanin#261.
kdeldycke
added a commit
to kdeldycke/python-tabulate
that referenced
this pull request
Apr 6, 2026
Follow up on astanin#410; Refs astanin#260 and astanin#261.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the GitHub Flavored Markdown Spec, tables are formatted in all sorts of shapes.
But one common aspect is that the pipes separating the cells are padded by a space. This is acknowledged in python-tabulate with the padding=1 settings. But unfortunately this setting doesn't applies to the lineabove and linebelowheader lines.
This PR fixes this issue, by having the line separators renders with padding spaces between the pipes and dashes.