fix: Correctly pass numparse to _type call in _wrap_text_to_colwidths - #420
Open
BradleyKirton wants to merge 1 commit into
Open
fix: Correctly pass numparse to _type call in _wrap_text_to_colwidths#420BradleyKirton wants to merge 1 commit into
BradleyKirton wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋 I noticed the _type call in _wrap_text_to_colwidths was passing numparse as a positional argument which would set the has_invisible input rather than the numparse input.
I created this PR which now passes numparse as a keyword argument. One potential issue is the behavior of has_invisible was driven by whatever numparse was. In this implementation it defaults to True which is the argument default.
I have also included a test.