Check Jupyter notebooks by default, in sync with 0.6.0 - #96
AlexWaygood merged 3 commits into
Conversation
Sorry, something went wrong.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Co-authored-by: Micha Reiser <micha@reiser.io>
|
Sorry for the oversight on our end and thanks for PRing a fix. This looks good but I'm also a complete pre-commit noob (and non-user). @AlexWaygood would you mind taking a look. |
Sorry, something went wrong.
| # Run the linter. | ||
| - id: ruff | ||
| types_or: [ python, pyi, jupyter ] | ||
| types_or: [ python, pyi ] |
There was a problem hiding this comment.
types_or overwrites the default config in .pre-commit-hooks.yaml rather than extending it, correct? I think that's what we want this example to show, I'm just double-checking.
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, that's how everything in pre-commit works. Users can override anything.
Sorry, something went wrong.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Summary
Close #95
Test Plan