feat: add venv-path input for custom virtual environment location - #736
Closed
seemethere wants to merge 2 commits into
Closed
seemethere wants to merge 2 commits into
seemethere wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Allow users to specify a custom path for the virtual environment when using activate-environment. This is useful for CI workflows that need to create isolated venvs outside the working directory (e.g., in $RUNNER_TEMP) to avoid conflicts with project-level configurations. When venv-path is not specified, the default behavior remains unchanged (.venv in the working directory).
seemethere
force-pushed
the
seemethere/add_custom_venv_path
branch
from
9b64ecf to
c193917
Compare
January 20, 2026 21:20
eifinger
requested changes
Jan 21, 2026
Comment thread
src/setup-uv.ts
Outdated
| core.info("Activating python venv..."); | ||
| await exec.exec("uv", execArgs); | ||
| // Use custom venv path if provided, otherwise default to .venv in working directory | ||
| const venvPath = |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Let's move that to getVenvPath to encapsulate all logic there
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Fixed!
Sorry, something went wrong.
Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
eifinger
reviewed
Jan 21, 2026
Comment thread
src/setup-uv.ts
| } | ||
| } | ||
|
|
||
| function getVenvPath(): string { |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Is there a reason I am not seeing why the logic of this function cannot fully move to inputs.ts?
Sorry, something went wrong.
eifinger
added a commit
that referenced
this pull request
Feb 4, 2026
Allow customizing the venv location while preserving working-directory semantics via --directory. Supersedes: #736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to specify a custom path for the virtual environment when using activate-environment. This is useful for CI workflows that need to create isolated venvs outside the working directory (e.g., in $RUNNER_TEMP) to avoid conflicts with project-level configurations.
When venv-path is not specified, the default behavior remains unchanged (.venv in the working directory).
Also adds a CI test for this