Add keepdims argument to mean, std, var methods. - #11198
Merged
astrojuanlu merged 1 commit intoDec 30, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Somehow these had been missing.
astrojuanlu
approved these changes
Dec 30, 2020
astrojuanlu
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There were no test failures and the changes were small and tested, so I merged straight away. Please let me know if I should have waited a bit more 👍🏽 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@astrojuanlu - that was just right, I think; it just needed a second pair of eyes to be sure! |
Sorry, something went wrong.
astrofrog
pushed a commit
that referenced
this pull request
Mar 16, 2021
Add keepdims argument to mean, std, var methods.
eteq
pushed a commit
that referenced
this pull request
Mar 24, 2021
Add keepdims argument to mean, std, var methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow these had been missing.
Separated out from the MaskedQuantity work at #11127 (f3f82f4)
cc @astrojuanlu, @adrn - should be very simple review.