FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bugfix for truncated outputs when using `with_bounding_box=True` by WilliamJamieson · Pull Request #12380 · astropy/astropy · GitHub

Bugfix for truncated outputs when using with_bounding_box=True - #12380

Merged
astrofrog merged 1 commit into
astropy:mainfrom
WilliamJamieson:bugfix/truncated_output
Nov 4, 2021
Merged

Bugfix for truncated outputs when using with_bounding_box=True#12380
astrofrog merged 1 commit into
astropy:mainfrom
WilliamJamieson:bugfix/truncated_output

Conversation

WilliamJamieson commented Nov 3, 2021
edited by nden
Loading

Copy link
Copy Markdown
Contributor

Description

For models with n_outputs=1 sometimes the outputs are truncated to just the first input when using the with_bounding_box=True keyword argument. This was fixed by calling on the slightly more sophisticated logic
present in the get_bounding_box() method for Model instead of a few basic tests on the with_bounding_box keyword argument.

Fixes #12373

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

Copy link
Copy Markdown
Contributor Author

tagging @nden and @perrygreenfield for review.

WilliamJamieson force-pushed the bugfix/truncated_output branch from 9dacebf to 93cc98c Compare November 3, 2021 23:37
nden added this to the v5.0 milestone Nov 4, 2021
nden added Affects-dev PRs and issues that do not impact an existing Astropy release backport-v5.0.x labels Nov 4, 2021

nden commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

This fixes the error in jwst. Can you add a docstring to get_bounding_box? And rebase and squash.

WilliamJamieson force-pushed the bugfix/truncated_output branch from 93cc98c to 17c648c Compare November 4, 2021 01:29

Copy link
Copy Markdown
Contributor Author

Can you add a docstring to get_bounding_box?

Note that these lines in PR #12364 add a better docstring to get_bounding_box.

Initial fix for bug

Extended test to include a bounding box

Added regression test for compound models having the same issue

Fixed issue for compound models as well

Added changelog
WilliamJamieson force-pushed the bugfix/truncated_output branch from 781f13c to b939f8a Compare November 4, 2021 12:53

nden commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Failure is unrelated.

astrofrog merged commit 7cbdf7a into astropy:main Nov 4, 2021
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Nov 4, 2021
WilliamJamieson deleted the bugfix/truncated_output branch November 4, 2021 15:03
astrofrog added a commit that referenced this pull request Nov 4, 2021
…380-on-v5.0.x

Backport PR #12380 on branch v5.0.x (Bugfix for truncated outputs when using `with_bounding_box=True`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release modeling no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Truncated output when evaluating a model with n_outputs=1

3 participants


Back | FazBrowse Home | New Git URL