Bug fixes in astropy.visualization.wcsaxes - #20221
Draft
astrofrog wants to merge 22 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… so a conflict does not leave earlier keys applied
…fix from axis_type_split
…o the hourangle format override works for non-interned degree units
…evious tick-placement implementation
… 1-d WCS by building the empty pixel array per pixel dimension
…mpty pixel input instead of the transposed (dims, N) shape
…efer to pixel coordinates instead of world coordinates
Copy link
Copy Markdown
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Sorry, something went wrong.
… multiple intersections along one spine
…regexes so malformed formats raise ValueError instead of silently dropping precision
… of the coordinate native unit
…gridlines with fewer than three sample points
…der in auto_assign_coord_positions
…no consistent spine assignment exists
…Error in format_coord
…n one tick label is a prefix of the adjacent one
astrofrog
force-pushed
the
wcsaxes-review-fixes
branch
from
b5b5787 to
b529a00
Compare
August 6, 2026 23:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the result of an automated review with Claude Opus of the astropy.visualization.wcsaxes submodule. I asked it to keep fixes as simple as possible, keep commit messages concise, and I then reviewed each and every change in detail and iterated on these and dropped some of the fixes. I have included only what I consider non-controversial concise fixes in this PR.
For now I'll keep this as a draft to give me a chance to do another round of review, and to make sure the CI is passing (in particular the image tests). In addition, this will need changelog entries.
So to be clear, the fixes and tests were written by Claude, but I have reviewed every single line and take responsibility for the changes.