FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TST: Fix MarkInfo object in pytest 4 by pllim · Pull Request #8158 · astropy/astropy · GitHub

/ astropy Public

TST: Fix MarkInfo object in pytest 4 - #8158

Merged
astrofrog merged 1 commit into
astropy:masterfrom
pllim:pytest4-markinfo
Nov 20, 2018
ConversationCommits (1)ChecksFiles changed
Merged

TST: Fix MarkInfo object in pytest 4#8158
astrofrog merged 1 commit into
astropy:masterfrom
pllim:pytest4-markinfo

Conversation

pllim commented Nov 17, 2018

Copy link
Copy Markdown
Member

Fix #8144 . Credit goes to @nicoddemus (thank you)!

pllim added this to the v3.1 milestone Nov 17, 2018
pllim requested a review from mwcraig November 17, 2018 22:55

astropy-bot Bot commented Nov 17, 2018

Copy link
Copy Markdown

Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

codecov Bot commented Nov 17, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8158 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8158   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files         383      383           
  Lines       57860    57860           
  Branches     1056     1056           
=======================================
  Hits        50296    50296           
  Misses       6950     6950           
  Partials      614      614

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afe2af...10961fb. Read the comment docs.

MSeifert04 mentioned this pull request Nov 18, 2018
Merged
astrofrog merged commit f7db70d into astropy:master Nov 20, 2018
pllim deleted the pytest4-markinfo branch November 20, 2018 19:00
bsipocz pushed a commit that referenced this pull request Nov 23, 2018
Merge pull request #8158 from pllim/pytest4-markinfo
df6581d 
TST: Fix MarkInfo object in pytest 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

astrofrog astrofrog approved these changes
mwcraig Awaiting requested review from mwcraig
+1 more reviewer
nicoddemus nicoddemus approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

nddata no-changelog-entry-needed testing

Projects

None yet

Milestone

v3.1

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL