FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change link colour in unified theme by Cadair · Pull Request #58 · astropy/astropy-sphinx-theme · GitHub

/ astropy-sphinx-theme Public

Change link colour in unified theme - #58

Merged
astrofrog merged 2 commits into
astropy:mainfrom
Cadair:paint_the_shed
May 16, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Change link colour in unified theme#58
astrofrog merged 2 commits into
astropy:mainfrom
Cadair:paint_the_shed

Conversation

Cadair commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Cadair changed the title Change link colour Change link colour in unified theme May 12, 2026
astrofrog approved these changes May 12, 2026
View reviewed changes

astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, and more standard so hopefully less controversial 👍

Cadair commented May 12, 2026
View reviewed changes
Comment thread astropy_sphinx_theme/astropy-unified/static/css/astropy.css Outdated
.navbar-nav .concertina-toggle:hover,
.bd-header .dropdown-item:hover,
.bd-header .concertina-toggle:hover {
color: var(--sst-accent-color-muted); /* Override the header link color back to sunpy */

Cadair May 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've made the links in the header bright as the default pst colours do not make the required contrast against the lighter background colour of the nav bar.

Cadair mentioned this pull request May 12, 2026
Merged
1 task

Cadair commented May 12, 2026

Copy link
Copy Markdown
Member Author

@taldcroft would you like to review this?

taldcroft approved these changes May 12, 2026
View reviewed changes

taldcroft left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Assuming that the theme colors apply to the preview artifacts, then looks good. Thanks!

Unrelated, but the section title "New astropy theme colors" should probably be changed to "Astropy theme colors" since they are now (or will soon be) not "new". But that is out of scope here.

astrofrog merged commit 11544f3 into astropy:main May 16, 2026
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

astrofrog astrofrog approved these changes
+1 more reviewer
taldcroft taldcroft approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL