FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Filter out astropy core package from pyOpenSci Affiliated listing by pllim · Pull Request #699 · astropy/astropy.github.com · GitHub

/ astropy.github.com Public

Filter out astropy core package from pyOpenSci Affiliated listing - #699

Merged
hamogu merged 1 commit into
astropy:mainfrom
pllim:fix-affil-filter
Jan 21, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Filter out astropy core package from pyOpenSci Affiliated listing#699
hamogu merged 1 commit into
astropy:mainfrom
pllim:fix-affil-filter

Conversation

pllim commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

pllim marked this pull request as ready for review January 20, 2026 18:54
pllim requested review from dhomeier and hamogu January 20, 2026 18:54
pllim mentioned this pull request Jan 20, 2026
Merged
11 tasks
hamogu requested changes Jan 21, 2026
View reviewed changes

hamogu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I still see it listed. Is the name "astropy" or did PyOpenSci names it "astropy core package" (which doesn't trigger the continue statement)?

hamogu commented Jan 21, 2026

Copy link
Copy Markdown
Member

I also think the "maintainers" entry is not right but since our goal is not display the core package at all in this list, we don't have to worry about that at this point.
(And @pllim already pointed out in pyOpenSci/software-submission#251 that the author/maintainer field is messed up upstream).

pllim commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

@hamogu , I don't think my code touches Coordinated Packages listing at https://www.astropy.org/affiliated/index.html#coordinated-package-list

I think changing this one is out of scope here and should be done in a separate PR?

astropy.github.com/affiliated/registry.json

Line 120 in ed29abb

"maintainer": "Astropy Coordination Committee",

hamogu merged commit 6fa4a54 into astropy:main Jan 21, 2026
2 checks passed
pllim deleted the fix-affil-filter branch January 21, 2026 16:26

pllim commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

Thanks for the merge, @hamogu . Do you want me to open follow-up PR for Coordinated listing you pointed out at #699 (review) ?

hamogu mentioned this pull request Jan 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hamogu hamogu requested changes
dhomeier Awaiting requested review from dhomeier

Assignees

No one assigned

Labels

affiliated-packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Affiliated listing JS code to filter out astropy core package

2 participants

Back | FazBrowse Home | New Git URL