Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.23%. Comparing base (e3702c4) to head (0ae71d3).
⚠️ Report is 203 commits behind head on main.

@@           Coverage Diff           @@
##             main    #3590   +/-   ##
=======================================
  Coverage   73.22%   73.23%           
=======================================
  Files         226      226           
  Lines       21000    21010   +10     
=======================================
+ Hits        15378    15386    +8     
- Misses       5622     5624    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Build preview is on the RTD status check here: https://astroquery--3590.org.readthedocs.build/en/3590/

That logo customisation isn't in the new theme. We could add a svg of it to the logo spot in the sidebar?

ahh, this reminds me to circle back to the actual logo question. As for the colouring, I would agree that it would be nice to keep the customization even if it's just via an svg; the current theme is very very much astropy and I don't actually want to loose the branding of astroquery.

(I don't mind the top bar, but actually do mind that it only says astropy )

ditto, I'd like to keep astroquery branding, so please hold off on merging this until we have created the svg logo. Can we do that trivially from the old theme?

We could do something like this on photutils:

Put a logo up on the left sidebar?

can try this. If it works, where do we put it?

<?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 340 60" role="img" aria-label="astroquery:docs">
  <title>astroquery:docs</title>
  <style>
    .logo { font-family: 'Lato', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, sans-serif; font-size: 44px; }
    .a1 { font-weight: 600; fill: currentColor; }
    .a2 { font-weight: 300; fill: #EC5810; }
    .a3 { font-weight: 300; fill: currentColor; }
  </style>
  <text x="0" y="46" class="logo"><tspan class="a1">astro</tspan><tspan class="a2">query</tspan><tspan class="a3">:docs</tspan></text>
</svg>

Putting the logo below is... fine, I guess? But I like the docs as they are now, I don't like arbitrary change.

(I haven't played with the above at all; the font families are just ai-gen, but they're close to what we have now: "Lato", "proxima-nova", "Helvetica Neue", "Arial", sans-serif;. I don't know if the mac stuff is relevant)

Do you want to keep the :docs or do you want to make a more general astroquery logo? I can probably easily edit the astropy svgs to make whatever we want.

Here's one on a dark background, but I could make a dark and a light variant?

the last thing you posted is good - if we can have that sitting in the top left, I'm happy enough, I spose.

Ok, see last commit. I added it to the top of the index page as well.

https://astroquery--3590.org.readthedocs.build/en/3590/

Thanks for adding that @Cadair . I still don't love the aesthetics right now.... there's redundant labeling all around. I like astroquery's current more minimal look.

new:

current:

oh man, you don't have the font for that logo installed 🙈 I should add it to the CSS. It is included in the CSS, so why isn't it using it for the svg??

So remove it from the index page and just leave it in the sidebar?

So remove it from the index page and just leave it in the sidebar?

yeah I think so

argh, fonts.

How about now? I don't know what's up with the fonts?

I like astroquery's current more minimal look.

unfortunately we'll need to move on from that, we even have a (or more) many years old issue(s) for that. At some point Clara was about to change stuff but she also went nuclear with mixing theme changes with content rather than doing piecemeal so it couldn't be merged.