FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Create plug that loads the current tenant assign from a given header… by t00lmaker · Pull Request #60 · ateliware/triplex · GitHub

/ triplex Public

Create plug that loads the current tenant assign from a given header… - #60

Closed
t00lmaker wants to merge 27 commits into
ateliware:masterfrom
t00lmaker:add_plug_header
ConversationCommits (27)ChecksFiles changed
Closed

Create plug that loads the current tenant assign from a given header…#60
t00lmaker wants to merge 27 commits into
ateliware:masterfrom
t00lmaker:add_plug_header

Conversation

t00lmaker commented Oct 31, 2018

Copy link
Copy Markdown

Create plug hat loads the current tenant assign from a given header…

coveralls commented Oct 31, 2018 •
edited
Loading

Copy link
Copy Markdown

Coverage decreased (-2.2%) to 86.829% when pulling 927a3ab on t00lmaker:add_plug_header into f49c43f on ateliware:master.

kelvinst reviewed Oct 31, 2018
View reviewed changes
Comment thread package-test/LICENSE Outdated
@@ -0,0 +1,21 @@
MIT License

kelvinst Oct 31, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you remove this whole folder and amend it to the previous commit? We don't need this. :)

kelvinst suggested changes Oct 31, 2018
View reviewed changes

kelvinst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Left some comments. Also, please remove the triplex-1.3.0-dev.tar file you commited.

kelvinst suggested changes Oct 31, 2018
View reviewed changes
Comment thread lib/mix/triplex.ex Outdated
Update lib/mix/triplex.ex
4316f51 
Co-Authored-By: t00lmaker <luanpontes2@gmail.com>

mgiacomini commented Nov 6, 2018

Copy link
Copy Markdown
Contributor

@t00lmaker could you resolve the mix.exs conflicts before we merge this pr?

kelvinst commented Mar 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for the PR! We will review and merge it soon!

Also, this will be released on version 1.4, which we will also extract a triplex_plugs lib with the plugs there, so triplex will no longer have these here.

GusGA commented Apr 19, 2019

Copy link
Copy Markdown

This PR could be helpful to others and looks abandoned, Can I fork it and fix the issues so could be merged?

kelvinst commented May 31, 2019

Copy link
Copy Markdown
Contributor

@GusGA we are moving all the plugs from this repo to another one, and we will probably move this one altogether. @mgiacomini please do not forget to copy the plug of this PR to that new triplex_plugs project.

ghost commented May 31, 2019

Copy link
Copy Markdown

Excellent news @kelvinst, thanks for your effort.

kelvinst commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

Hey @mgiacomini, let's merge this to master before separating the plugs on another repository. SO that way @t00lmaker takes the credit for it at least. 😄 Thanks BTW.

kelvinst changed the title Create plug hat loads the current tenant assign from a given header… Create plug that loads the current tenant assign from a given header… Sep 16, 2019
kelvinst suggested changes Sep 16, 2019
View reviewed changes

kelvinst left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I deleted all the package-test files you added, but cannot delete triplex-1.3.0-dev.tar, @t00lmaker can you delete and update the PR please?

kelvinst mentioned this pull request Sep 16, 2019
Open

mgiacomini commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

Hey @mgiacomini, let's merge this to master before separating the plugs on another repository. SO that way @t00lmaker takes the credit for it at least. 😄 Thanks BTW.

Sure!

t00lmaker closed this Oct 26, 2019
t00lmaker deleted the add_plug_header branch October 26, 2019 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
kelvinst kelvinst requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL