FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes #11190 by alazaro · Pull Request #11463 · atom/atom · GitHub

This repository was archived by the owner on Mar 3, 2023. It is now read-only.
/ atom Public archive

Fixes #11190 - #11463

Merged
lee-dohm merged 1 commit into
atom:masterfrom
alazaro:skip-env-patching-fish
Apr 18, 2016
Merged

lee-dohm merged 1 commit into
atom:masterfrom
alazaro:skip-env-patching-fish

Conversation

alazaro commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

This is the error thrown when starting Atom from Spotlight on Mac or by double clicking on the App and the default shell is fish-shell.
I attach a Snapshot of the error, that doesn't happen anymore after the fix.

Copy link
Copy Markdown
Contributor

Shouldn't this fix #11190 and not #4126?

alazaro changed the title Fixes #4126 for fish-shell Fixes #11190 Apr 18, 2016

alazaro commented Apr 18, 2016

Copy link
Copy Markdown
Contributor Author

@50Wliu You're right

Copy link
Copy Markdown
Contributor

/cc @lee-dohm

lee-dohm merged commit d25347d into atom:master Apr 18, 2016

Copy link
Copy Markdown
Contributor

Thanks for this!

Copy link
Copy Markdown

After this pull request Atom is not reading paths added by fish-shell when starting from Spotlight or with double click. Correctly reads paths only when started directly from shell, e.g. with atom command.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL