FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add clean script by shama · Pull Request #1309 · atom/atom · GitHub

This repository was archived by the owner on Mar 3, 2023. It is now read-only.
  1. atom
  2. atom

Repository navigation

Add clean script - #1309

Merged
kevinsawicki merged 4 commits into
atom:masterfrom
shama:cleanscript
Dec 17, 2013
ConversationCommits (4)ChecksFiles changed
Merged

Add clean script#1309
kevinsawicki merged 4 commits into
atom:masterfrom
shama:cleanscript

Conversation

shama commented Dec 13, 2013

Copy link
Copy Markdown
Contributor

Fixes #1248

kevinsawicki reviewed Dec 13, 2013
View reviewed changes
Comment thread script/clean Outdated

kevinsawicki Dec 13, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

rimraf won't be around anymore after you run this right since node_modules is blown away?

So running it a second time would fail unless I'm missing something, wonder what else we could do.

shama Dec 13, 2013

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah right, let me try updating to just var rimraf = process.platform === 'win32' ? 'rm -rf ' : 'del /s /f '; and test if that is sufficiently cross-platform.

shama commented Dec 15, 2013

Copy link
Copy Markdown
Contributor Author

Updated and is now no longer dependent on node_modules. Also now it won't error if atom is not currently running when trying to kill it.

kevinsawicki reviewed Dec 16, 2013
View reviewed changes
Comment thread script/clean Outdated

kevinsawicki Dec 16, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this should be .node-gyp

shama commented Dec 16, 2013

Copy link
Copy Markdown
Contributor Author

Updated.

@probablycorey are there any other folders that should be cleaned? (I pulled them originally from your list) Thanks!

probablycorey commented Dec 16, 2013

Copy link
Copy Markdown

@shama Those are the only ones I could think of after a long think! Looks good!

probablycorey reviewed Dec 16, 2013
View reviewed changes
Comment thread script/clean Outdated

probablycorey Dec 16, 2013

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe rename rimraf to removeCommand or something like that? When I see rimraf I think it is the rimraf node module.

shama commented Dec 17, 2013

Copy link
Copy Markdown
Contributor Author

Updated, thanks!

kevinsawicki added a commit that referenced this pull request Dec 17, 2013
Merge pull request #1309 from shama/cleanscript
5b4b57f 
Add clean script
kevinsawicki merged commit 5b4b57f into atom:master Dec 17, 2013

kevinsawicki commented Dec 17, 2013

Copy link
Copy Markdown
Contributor

Awesome, thanks!

shama deleted the cleanscript branch December 17, 2013 02:24
aliceUnhinged613 mentioned this pull request May 13, 2022
Open
rx007 mentioned this pull request May 13, 2022
Open
one3chens mentioned this pull request May 13, 2022
Open
srmibextesting mentioned this pull request May 13, 2022
Open
HelloKittyHacker mentioned this pull request May 13, 2022
Open
leo191 mentioned this pull request May 13, 2022
Open
eliasbuchwald mentioned this pull request May 13, 2022
Open
restinpeaceinout mentioned this pull request May 13, 2022
Open
HelloKittyHacker mentioned this pull request May 13, 2022
Open
summer-pockets mentioned this pull request May 13, 2022
Open
snyk-bot mentioned this pull request May 13, 2022
Open
EC-Snyk mentioned this pull request May 13, 2022
Open
restinpeaceinout mentioned this pull request May 13, 2022
Open
Matthelonianxl mentioned this pull request May 13, 2022
Open
This was referenced Oct 6, 2022
Open
Open
This was referenced Oct 6, 2022
Open
Open
This was referenced Oct 6, 2022
Open
Open
This was referenced Oct 7, 2022
Open
Open
Open
This was referenced Oct 7, 2022
Open
Open
snyk-bot mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 7, 2022
Open
Open
Open
Open
machatman mentioned this pull request Oct 8, 2022
Open
snyk-bot mentioned this pull request Oct 8, 2022
Open
This was referenced Oct 8, 2022
Open
Open
This was referenced Oct 9, 2022
Open
Open
Open
Open
matt-glich mentioned this pull request Oct 9, 2022
Open
This was referenced Oct 9, 2022
Open
Open
This was referenced Apr 4, 2023
Closed
Open
domsavatta2 mentioned this pull request Oct 23, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create script/clean

3 participants

Back | FazBrowse Home | New Git URL