This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Repository navigation
Use previous definition of scope selector match to fix API breakage - #6987
Merged
kevinsawicki merged 1 commit intoMay 28, 2015
Merged
kevinsawicki merged 1 commit into
kevinsawicki merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
I switched to first-mate Selector because I didn’t want to replicate the poorly-defined Token::matchesScopeSelector method now that tokens are not stored on lines. However, the first-mate semantics are stricter and that broke the API. Perhaps using selector-kit here would be better, but I just wanted to put back exactly to how it was for now. /cc @ypresto
kevinsawicki
added a commit
that referenced
this pull request
May 28, 2015
…osition Use previous definition of scope selector match to fix API breakage
Copy link
Copy Markdown
Contributor
|
Thanks for fixing this 👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks!!! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I switched to first-mate Selector because I didn’t want to replicate the poorly-defined Token::matchesScopeSelector method now that tokens are not stored on lines. However, the first-mate semantics are stricter and that broke the API. Perhaps using selector-kit here would be better, but I just wanted to put back exactly to how it was for now.
@kevinsawicki we need to merge this and release ASAP to fix railroad diagrams and probably some other packages. Sorry about this everybody.
/cc @ypresto