FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added support for type grouping when initializing or when calling make by roeest · Pull Request #74 · atom/language-go · GitHub

This repository was archived by the owner on Dec 15, 2022. It is now read-only.
/ language-go Public archive

Added support for type grouping when initializing or when calling make - #74

Open
roeest wants to merge 1 commit into
atom:masterfrom
roeest:master
Open

roeest wants to merge 1 commit into
atom:masterfrom
roeest:master

Conversation

roeest commented Dec 2, 2015

Copy link
Copy Markdown

No description provided.

Comment thread grammars/go.cson

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This can be simplified to just

'1':
  'include': '#types'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It stops working when i do that

Copy link
Copy Markdown
Contributor

I see the thing you're trying to solve, but I think it could be solved in a much cleaner way...

You should have a look at how this is solved with multiline variable declarations which are essentially the same thing, but then for variables instead of types.

Especially have a look at the use of 'include': '$self' which helps to prevent duplication code.

roeest commented Dec 3, 2015

Copy link
Copy Markdown
Author

@svanharmelen - I looked at the variable declaration section, im not sure i understand how the $self syntax is helpful for what i'm trying to achieve here

Copy link
Copy Markdown
Contributor

@svanharmelen is there a path forward on this PR?

Copy link
Copy Markdown
Contributor

@joefitzgerald I'm sorry, but I have to admit that I switched back to vim about 10 months ago. So I don't think I'm still the right person to judge this PR...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL