This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Implement naming conventions in JavaScript and Regex grammars - #690
Open
chbk wants to merge 1 commit into
Open
chbk wants to merge 1 commit into
chbk wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Author
|
Preview of the changes with Atom's default syntax themes:
Code snippet: import * as empire from 'galaxy'
class Terminus extends empire.Planet {
static hologram() {
return super.psychohistory
}
get plan() {
return (
<div class={this.axiom + 1}>
<Council speaker="first"/>
</div>
)
}
}
vault = Terminus.hologram(true)
cleonII = new empire.Trantor.Ruler()
@future
function seldonCrisis(...years) {
let riddle = "a circle has"
riddle += `${years[0]} no end`
console.log(riddle)
return [...arguments]
}
if (magnifico === undefined) {
let search = Infinity
}
robotics.map(law =>
law.replace(/^H(?:.*\w)\n$/i, "0")
)
/** @type {number} */
const PARSEC = 2.06265 * 1e5
export function *travel() {
yield {
distance: 16204 * PARSEC,
destination: "star's end"
}
} |
Sorry, something went wrong.
This was referenced Jan 12, 2021
chbk
force-pushed
the
scopes
branch
3 times, most recently
from
3e95ffb to
2bce328
Compare
January 18, 2021 10:47
This was referenced Jan 30, 2021
chbk
marked this pull request as ready for review
February 1, 2021 14:32
icecream17
added a commit
to icecream17/pulsar
that referenced
this pull request
Oct 2, 2022
The non-tree sitter version is almost completely copied so nothing to say there. There are some inconsistencies/missing operators in the tree-sitter version, for example: - `this` - `new.target` - `import.meta` - The keyword.operator order looks more wrong the more I look at it but that's for another day because of the possible scope regularity change in the future: atom/language-javascript#690 - btw atom/language-javascript#691 looks good to me I should probably do that Even though tree-sitter will have some above changes I added the new operators (`** **= ?? &&= ||= ??= void`) anyway. Well `void` is not new it's just missing. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators for a list of operators. Of course while the comma is technically an operator, hopefully it's used more to separate elements in arrays or properties in objects. Also `delete` is an operator not control.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is a rewrite of the Tree-sitter grammar to implement naming conventions for syntax scopes.
Benefits
Possible Drawbacks
Some new scopes to be added to themes. The changes aim to facilitate theme development, filling the template is enough to ensure coherent highlighting across languages, instead of painfully creating styling rules for every language separately.
Applicable Issues
Related Pull Requests