This repository was archived by the owner on Dec 15, 2022. It is now read-only.
use let instead of var to define loop variables - #714
Open
MichaelKreil wants to merge 1 commit into
Open
MichaelKreil wants to merge 1 commit into
MichaelKreil wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
icecream17
approved these changes
Mar 21, 2022
Copy link
Copy Markdown
Contributor
|
Actually I redact that approval since there's one that also uses const, see #691 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Use "let" instead of "var" to define loop variables.
Alternate Designs
I can't see any other approaches.
Benefits
Defining loop variables with "var" can lead to unwanted side effects. Therefore it is recommended to use "let".
Possible Drawbacks
There might be some developers who are not using ES6, like very old legacy versions of node.js. I believe node.js uses "let" since version 4.0.
Applicable Issues
At some point, we will have to switch to "let". The question is: when, if not now?