This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Handle files with first line shell opts. - #171
Open
ladar wants to merge 1 commit into
Open
ladar wants to merge 1 commit into
ladar wants to merge 1 commit into
Conversation
This should match: ``` #!/bin/bash ``` and ``` #!/bin/bash -eu ``` Currently the latter isn't being matched because the regex requires a new line after `sh` or `bash`.
icecream17
approved these changes
Dec 16, 2021
Copy link
Copy Markdown
Author
|
@icecream17 thank you for reviewing. It's always nice to see another Texan on GitHub. @sadick254 can we get this regex tweak merged before the next release? There hasn't been any activity in this repo since April, so reaching since you appear to have commit access. Should I increment the package.json before you merge, or will you handle that? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
The shell script grammar should be applied to:
and
But with the current release, the latter isn't being matched because the regex requires a new line after sh or bash. This regex tweak fixes that oversight.