This repository was archived by the owner on Dec 15, 2022. It is now read-only.
chore: update tree-sitter-bash - #172
Open
claytonrcarter wants to merge 1 commit into
Open
claytonrcarter wants to merge 1 commit into
claytonrcarter wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This was referenced May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This updates the tree-sitter-bash dependency to a version compatible w/ the latest version of the tree-sitter ABI 13. This is required if Atom is going to update to a newer version tree-sitter, and is a prerequisite for atom/atom#23283. Tests are passing locally (on a mac) but note that the tree-sitter grammar for this package (like most other tree-sitter grammars) doesn't have any specific tests.
Alternate Designs
n/a
Benefits
Keeps dependencies up to date; allows Atom to keep it's dependencies up to date.
Possible Drawbacks
If merged, this package will not work with Atom until it also updates to tree-sitter 0.19 or 0.20. This is no different than several other packages (language-javascript, language-css, language-go and language-c are already updated)
Applicable Issues
atom/atom#23283, atom/atom#22129, https://github.com/icecream17/atom-update-backlog/blob/main/Languages.md