Fix -- Read the payload written by withPayload #725 - #727
Open
marktech0813 wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
I added two convenience methods to expose decoded JSON without changing existing behavior. Now you can access both decoded header and payload directly from any DecodedJWT. You can now use: - Decoded payload JSON: decoded.getPayloadJson() - Decoded header JSON: decoded.getHeaderJson()
Copy link
Copy Markdown
Contributor
|
Thank you raising the PR. I have reviewed the changes, but wanted to highlight few things. Exposing decoded header or payload JSON directly may encourage consumers to rely on unverified JWT data, since decoding does not imply signature verification. While the data is already accessible today, adding a dedicated API makes this usage more prominent. Can we adding more intuitive naming as getDecodedPayloadJson() and getDecodedHeaderJson(), this prevents from accidental usage? Thank you |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added two convenience methods to expose decoded JSON without changing existing behavior. Now you can access both decoded header and payload directly from any DecodedJWT.
You can now use:
Changes
Please describe both what is changing and why this is important. Include:
References
Please include relevant links supporting this change such as a:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist
Contribution by Gittensor, learn more at https://gittensor.io/