| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
CI is running here now, once Green, we'll have a review soon. Also, can you add couple of integration tests as well? |
Sorry, something went wrong.
|
Hi @officialasishkumar @authorjapps — I saw #784 was still open asking for the missing integration test scenario for this timezone-aware datetime fix, so I put one together. It's on my fork here: Huzi-06/zerocode branch add-timezone-integration-test It adds http-testing-examples/src/test/resources/helloworld_date/hello_world_date_timezone_aware_test.json, covering all four supported formats from the acceptance criteria:
Ran locally against this branch and both tests pass (HelloWorldDateAfterBeforeTest). Happy to have this cherry-picked into #771 directly, or I can open it as a small follow-up PR, whichever's easier for you. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Support timezone-aware datetime assertions
Fixed Which Issue?
PR Branch
https://github.com/officialasishkumar/zerocode/tree/issue-268-date-timezone
Motivation and Context
$LOCAL.DATETIME.AFTER and $LOCAL.DATETIME.BEFORE parsed ISO datetimes into LocalDateTime, which ignored offset semantics for values such as Z or +02:00. That meant comparisons used the wall-clock value instead of comparing equivalent instants.
This change adds a shared datetime parser for assertion expected values and actual response values. It preserves plain ISO local datetime support, honors ISO offsets and Z, and adds RFC-1123 HTTP-date parsing for values such as Last-Modified.
Validation run locally:
mvn -pl core -Dtest=ZeroCodeAssertionsProcessorImplTest test -ntpChecklist:
1. New Unit tests were added
2. Integration tests were added
3. Test names are meaningful
3.1 Feature manually tested and outcome is successful
4. PR doesn't break any of the earlier features for end users
5. PR doesn't break the HTML report features directly
6. PR doesn't break any HTML report features indirectly
7. Branch build passed in CI
8. No 'package.*' in the imports
9. Relevant DOcumentation page added or updated with clear instructions and examples for the end user
10. Http test added to http-testing-examples module(if applicable) ?
11. Kafka test added to kafka-testing-examples module(if applicable) ?