FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DYN-10011: Return runtime concrete type for types implementing .NET interfaces by aparajit-pratap · Pull Request #5 · autodesk-forks/pythonnet · GitHub

/ pythonnet Public
forked from pythonnet/pythonnet

DYN-10011: Return runtime concrete type for types implementing .NET interfaces - #5

Closed
aparajit-pratap wants to merge 10 commits into
autodesk-forks:dynamo_py3from
aparajit-pratap:dyn-10011
ConversationCommits (10)ChecksFiles changed
Closed

DYN-10011: Return runtime concrete type for types implementing .NET interfaces#5
aparajit-pratap wants to merge 10 commits into
autodesk-forks:dynamo_py3from
aparajit-pratap:dyn-10011

Conversation

aparajit-pratap commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown

What does this implement/fix? Explain your changes.

Background: When a .NET method returns a concrete type that implements an interface, e.g. IDisposable, pythonnet incorrectly resolves the object as the interface type instead of the concrete type. This prevents access to the concrete type's members and breaks common patterns using Python's with statement for resource management with IDisposable types.

This PR attempts to fix the above issue.

Does this close any currently open issues?

...

Any other comments?

Reviewers:
@zeusongit
@twastvedt
@zavub

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

twastvedt commented Jan 9, 2026

Copy link
Copy Markdown

Is it feasible to add a test for this?

aparajit-pratap commented Jan 9, 2026
View reviewed changes
Comment thread Directory.Build.props

aparajit-pratap commented Jan 9, 2026

Copy link
Copy Markdown
Author

Is it feasible to add a test for this?

I know how to add a test for this in Dynamo. Will explore how I can add a test to this project.

RobertGlobant20 approved these changes Jan 9, 2026
View reviewed changes

RobertGlobant20 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

twastvedt approved these changes Jan 12, 2026
View reviewed changes

twastvedt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like test CI needs some attention, but if this runs locally, looks good to me.

aparajit-pratap commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@twastvedt, my latest commit doesn't seem to have triggered the github workflows again. Any idea how I can manually trigger them?

aparajit-pratap commented Jan 14, 2026

Copy link
Copy Markdown
Author

Closing in favor of #6

aparajit-pratap deleted the dyn-10011 branch January 15, 2026 20:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

twastvedt twastvedt approved these changes
+1 more reviewer
RobertGlobant20 RobertGlobant20 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL