Source distribution - #7668
Merged
stealthycoin merged 21 commits intoFeb 15, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Changes: * Add python interface for building from source under backends/build_system * Add autotools interface for calling the python build backend * Add requirements/lock files under requirements/ directory needed for building form source. * Add script for regenerating the requirements lock files from scratch. * add .gitignore entries for autotools
* Refresh the regenerate-lock-files script. * Referesh the lock files using the updated script. * Add a test which checks the lock files are synced with the plain requirements files.
Script to regenerate configure file uses pinned versions of automake and autotools inside a docker image to ensure consistent configure output.
When building a portable exe dist from source you will now get the distribuiton metadtata "source-exe". When building a system-sandbox dist from source you will now get the distribuiton metadtata "source-sandbox".
This makes it easier to install all of the dependencies if you do not want to --use-download-deps.
Add error message when flit_core is not installed
kyleknap
reviewed
Feb 14, 2023
kyleknap
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good. Just had one small comment.
Sorry, something went wrong.
Comment thread
configure.ac
Outdated
| @@ -0,0 +1,58 @@ | |||
| AC_CONFIG_MACRO_DIRS([m4]) | |||
| AC_INIT([awscli], [2.7.31]) | |||
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
We should probably update this to the current version of v2 is now. It will automatically get bumped but it would be good to see it be in sync to start.
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## v2 #7668 +/- ##
=======================================
Coverage 93.03% 93.04%
=======================================
Files 354 354
Lines 37452 37452
Branches 6008 6008
=======================================
+ Hits 34845 34847 +2
+ Misses 1950 1949 -1
+ Partials 657 656 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sorry, something went wrong.
kyleknap
approved these changes
Feb 15, 2023
kyleknap
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good 🚢
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR to merge the ongoing feature branch source-distribution into v2.