removed unnecessary usage of public on interface methods - #172
Merged
andclt merged 1 commit intoAug 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
msailes
force-pushed
the
runtime-interface-cleanup
branch
from
d57e260 to
ab5d5c5
Compare
August 10, 2022 08:09
msailes
self-requested a review
August 10, 2022 08:09
msailes
approved these changes
Aug 10, 2022
msailes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
andclt
approved these changes
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the definition of an Interface (https://docs.oracle.com/javase/tutorial/java/IandI/interfaceDef.html), the public modifier can be omitted.
@bmoffatt
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.