1.0.1 lambda-java-serialization release - #379
Merged
smirnoal merged 3 commits intoNov 22, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
msailes
reviewed
Nov 21, 2022
Comment thread
aws-lambda-java-serialization/RELEASE.CHANGELOG.md
Outdated
andclt
approved these changes
Nov 21, 2022
anton-stepanof
approved these changes
Nov 21, 2022
msailes
approved these changes
Nov 21, 2022
msailes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LTGM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
With this update, I have the following error : java.io.UncheckedIOException: com.amazonaws.lambda.thirdparty.com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Joda date/time type `org.joda.time.DateTime` not supported by default: add Module "com.amazonaws.lambda.thirdparty.com.fasterxml.jackson.datatype:jackson-datatype-joda" to enable handling at [Source: (BufferedInputStream); line: 13, column: 22] (through reference chain: com.amazonaws.services.lambda.runtime.events.SNSEvent["Records"]->java.util.ArrayList[0]->com.amazonaws.services.lambda.runtime.events.SNSEvent$SNSRecord["Sns"]->com.amazonaws.services.lambda.runtime.events.SNSEvent$SNS["Timestamp"]) When adding the following dependency: <dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-joda</artifactId>
<version>2.14.0</version>
</dependency>
and adding the JodaModule in com.amazonaws.services.lambda.runtime.serialization.events.LambdaEventSerializers: factory.getMapper().registerModules(new DateModule(), new DateTimeModule(classLoader), new JodaModule()); I have the following one: java.io.UncheckedIOException:
com.amazonaws.lambda.thirdparty.com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of `org.joda.time.DateTime` (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('2020-10-08T16:06:14.656Z')
at [Source: (BufferedInputStream); line: 13, column: 22] (through reference chain: com.amazonaws.services.lambda.runtime.events.SNSEvent["Records"]->java.util.ArrayList[0]->com.amazonaws.services.lambda.runtime.events.SNSEvent$SNSRecord["Sns"]->com.amazonaws.services.lambda.runtime.events.SNSEvent$SNS["Timestamp"])
Am I missing something? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
thanks for reporting that, do you mind sharing a unit test for this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
if you update aws-lambda-java-tests with this new version and run tests, you'll get it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 more reviewers5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update Jackson dependencies, junit version, owasp plugin version
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.