New ScheduledV2Event implementation - #480
Conversation
Sorry, something went wrong.
and fix for APIGatewayV2CustomAuthorizerEventTest when running on the non-US locale machine
smirnoal
left a comment
There was a problem hiding this comment.
please add a test to aws-lambda-java-tests covering this event
Sorry, something went wrong.
| @@ -0,0 +1,366 @@ | |||
| /* | |||
There was a problem hiding this comment.
please update the header to
/* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. SPDX-License-Identifier: Apache-2.0 */
Sorry, something went wrong.
|
|
||
| @BeforeAll | ||
| static void beforeAll() { | ||
| Locale.setDefault(new Locale("en", "US")); |
There was a problem hiding this comment.
thanks for this
Sorry, something went wrong.
| import java.util.List; | ||
|
|
||
| /** | ||
| * represents a scheduled V2 event |
There was a problem hiding this comment.
Can you add a link to the documentation in the header please.
Sorry, something went wrong.
|
|
||
| private String region; | ||
|
|
||
| private String detail; |
There was a problem hiding this comment.
I think we (AWS) needs to validate that there will be no events where detail will be anything other than a String for scheduled task use cases.
Sorry, something went wrong.
|
We also probably want to consider how we explain the difference between ScheduledEvent and ScheduledV2Event. Are we deprecating ScheduledEvent? |
Sorry, something went wrong.
|
PR updated. Sorry for delay. |
Sorry, something went wrong.
| * @see Object#toString() | ||
| */ | ||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
https://projectlombok.org/features/Data includes toString, hashcode and equals, you can remove those, and the clone method.
Sorry, something went wrong.
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
|
|
||
| /** | ||
| * Represents a Scheduled V2 event sent to Lambda | ||
| * <a href="https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-function-schedulev2.html">ScheduleV2</a> |
There was a problem hiding this comment.
I think this is a link to the wrong page.
Sorry, something went wrong.
There was a problem hiding this comment.
This one should be more valid. 😉
Sorry, something went wrong.
and fix for APIGatewayV2CustomAuthorizerEventTest when running on the non-US locale machine.
Issue #, if available:
No. 479: #479
Description of changes:
New Java class ScheduledV2Event has been added. Additionally change is related to APIGatewayV2CustomAuthorizerEventTest which didn't pass on non-US locale Java machine. Now default locale for both tests from this class are running under US-en locale.
Target (OCI, Managed Runtime, both):
both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.