| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| # This workflow will be triggered if there will be changes to aws-lambda-java-core | ||
| # package and it builds the package and the packages that depend on it. | ||
| # package and it builds the package. | ||
|
|
||
| name: Java CI aws-lambda-java-core | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: [ main ] | ||
| paths: | ||
| Expand All | @@ -29,18 +30,7 @@ jobs: | |
| with: | ||
| java-version: 8 | ||
| distribution: corretto | ||
|
|
||
| # Install base module | ||
| cache: maven | ||
|
Comment thread
Copy link
Copy Markdown
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualityby how much this is reducing the build time?
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityNot much, unfortunately a couple of seconds on the RIC. On the other you cannot even find it. It is useful however for development if you want to test you changes with a github run.
Sorry, something went wrong.
maxday reacted with thumbs up emoji
All reactions
|
||
|
|
||
| - name: Install core with Maven | ||
| run: mvn -B install --file aws-lambda-java-core/pom.xml | ||
|
|
||
| # Package modules that depend on base module | ||
| - name: Package log4j2 with Maven | ||
| run: mvn -B package --file aws-lambda-java-log4j2/pom.xml | ||
|
|
||
| # Test Runtime Interface Client | ||
| - name: Run 'pr' target | ||
| working-directory: ./aws-lambda-java-runtime-interface-client | ||
| run: make pr | ||
| env: | ||
| IS_JAVA_8: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -37,4 +37,4 @@ experimental/aws-lambda-java-profiler/integration_tests/helloworld/bin | |
| /scratch/ | ||
| .vscode | ||
| .kiro | ||
| build | ||
| build | ||
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityWill this still pick the latest local changes If we make a change to one of the dependencies?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityYes. The key is an hash of the pom file, so if you are changing the POM you will cause the local cache to download the deps.
https://github.com/actions/setup-java#caching-packages-dependencies
This is not ultra useful because when we make our changes we usually change also the POM, however I read there should be also a partial hit cache.
So we would have at least cached the external dependencies. This is definitely a minor improvement. I will delve in build performance in following PRs.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.