docs(runtime): document time_of_last_update field in /ping response - #517
Open
citizen204 wants to merge 1 commit into
Open
docs(runtime): document time_of_last_update field in /ping response#517citizen204 wants to merge 1 commit into
citizen204 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The /ping endpoint has always emitted both "status" and "time_of_last_update" but neither the PingStatus docstring nor _handle_ping explained the latter. Without it the platform idle-reaper fires even when status is HealthyBusy, silently killing containers mid-execution. Add docstrings to PingStatus and _handle_ping that describe the full response contract and warn that time_of_last_update is required. Fixes aws#471
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with 
GitHub Actions
Failure
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with
GitHub Actions
Failure
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with
GitHub Actions
Failure
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with
GitHub Actions
Failure
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with
GitHub Actions
Failure
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with
GitHub Actions
Failure
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with
GitHub Actions
Failure
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with
GitHub Actions
Failure
citizen204
had a problem deploying
to
manual-approval
June 13, 2026 10:00 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The /ping endpoint has always emitted {"status": "...", "time_of_last_update": <int>} (since commit 4f5c80d), but neither PingStatus nor _handle_ping had docstrings explaining that time_of_last_update is required for the platform's idle-reaper logic. Without this field, idleRuntimeSessionTimeout fires even while /ping returns HealthyBusy, silently killing containers mid-execution.
This is a pure documentation fix — no logic changes.
Fixes #471
Changes