FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: Prepare for 0.4.0-beta by pankajagrawal16 · Pull Request #116 · aws-powertools/powertools-lambda-java · GitHub

/ powertools-lambda-java Public

ci: Prepare for 0.4.0-beta - #116

Merged
pankajagrawal16 merged 3 commits into
masterfrom
0.4.0-beta
Oct 2, 2020
ConversationCommits (3)ChecksFiles changed
Merged

ci: Prepare for 0.4.0-beta#116
pankajagrawal16 merged 3 commits into
masterfrom
0.4.0-beta

Conversation

pankajagrawal16 commented Oct 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

pankajagrawal16 changed the title Prepare for 0.4.0-beta ci: Prepare for 0.4.0-beta Oct 1, 2020
jeromevdl reviewed Oct 2, 2020
View reviewed changes
Comment thread docs/content/utilities/sqs_large_message_handling.mdx
<version>0.3.1-beta</version>
<version>0.4.0-beta</version>
</dependency>
```

jeromevdl Oct 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

make me think I forgot to add this in the parameters doc (installation step):

<dependency>
    <groupId>software.amazon.lambda</groupId>
    <artifactId>powertools-parameters</artifactId>
    <version>0.4.0-beta</version>
</dependency>

pankajagrawal16 Oct 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

aha.. nevermind, I can fix it in same PR

jeromevdl reviewed Oct 2, 2020
View reviewed changes
Comment thread docs/content/index.mdx
<version>0.3.1-beta</version>
<version>0.4.0-beta</version>
</dependency>
...

jeromevdl Oct 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

metrics is not there? normal?

pankajagrawal16 Oct 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch. I guess we missed updating it when we launched metrics module 😉

jeromevdl approved these changes Oct 2, 2020
View reviewed changes

jeromevdl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good for me!

msailes approved these changes Oct 2, 2020
View reviewed changes

msailes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great!

pankajagrawal16 merged commit febb426 into master Oct 2, 2020
pankajagrawal16 deleted the 0.4.0-beta branch October 2, 2020 07:44
jeromevdl pushed a commit to jeromevdl/aws-lambda-powertools-java that referenced this pull request Oct 19, 2020
ci: Prepare for 0.4.0-beta (aws-powertools#116)
612a734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jeromevdl jeromevdl approved these changes
msailes msailes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL