FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(event_handler): read swagger files with UTF-8 encoding by JustinBerger · Pull Request #8131 · aws-powertools/powertools-lambda-python · GitHub

/ powertools-lambda-python Public

fix(event_handler): read swagger files with UTF-8 encoding - #8131

Merged
leandrodamascena merged 1 commit into
aws-powertools:developfrom
JustinBerger:develop
Apr 8, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix(event_handler): read swagger files with UTF-8 encoding#8131
leandrodamascena merged 1 commit into
aws-powertools:developfrom
JustinBerger:develop

Conversation

JustinBerger commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Issue number: closes #8129

Summary

Changes

  • When reading the swagger_ui js and css files, they are opened with UTF-8 encoding.

User experience

  • The js and css files will be loaded as UTF-8 regardless of the default encoding set on the runtime environment. Other than fixing the bug, I would not expect this to have an impact on user experience.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

JustinBerger requested a review from a team as a code owner April 8, 2026 14:56

boring-cyborg Bot commented Apr 8, 2026

Copy link
Copy Markdown

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

powertools-for-aws-oss-automation Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2026

sonarqubecloud Bot commented Apr 8, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov Bot commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.64%. Comparing base (12aeb50) to head (82eff76).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #8131   +/-   ##
========================================
  Coverage    96.64%   96.64%           
========================================
  Files          284      284           
  Lines        14079    14079           
  Branches      1153     1153           
========================================
  Hits         13606    13606           
  Misses         344      344           
  Partials       129      129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

leandrodamascena approved these changes Apr 8, 2026
View reviewed changes

leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey @JustinBerger thanks a lot for sending this PR and contributing to Powertools!

APPROVED!

leandrodamascena merged commit f1d07ab into aws-powertools:develop Apr 8, 2026
18 checks passed

boring-cyborg Bot commented Apr 8, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

leandrodamascena leandrodamascena approved these changes

Assignees

JustinBerger

Labels

event_handlers size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: API Gateway Swagger UI files are loaded using the default system encoding instead of UTF-8

2 participants

Back | FazBrowse Home | New Git URL