| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Sorry, something went wrong.
|
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## develop #8332 +/- ##
===========================================
- Coverage 96.63% 96.63% -0.01%
===========================================
Files 296 296
Lines 14759 14764 +5
Branches 1243 1244 +1
===========================================
+ Hits 14263 14267 +4
Misses 362 362
- Partials 134 135 +1 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Amazing work @stenczelt! Thanks a lot, APPROVED!
Sorry, something went wrong.
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Issue number: closes #8331
Summary
Changes
aws_lambda_powertools.utilities.data_classes.event_source complies with mypy in --strict mode as well.
Removed a redundant casting to the dataclass in examples/event_sources/src/kinesis_firehose_response_exception.py.
Changes are localised to event_source.py, rather than trying to annotate lambda_handler_decorator for all use cases, unlike earlier attempts, e.g. #4165. Since the decorator only takes the dataclass as a keyword argument, I've defined a protocol and cast the result to this.
User experience
Having a handler using the @event_source decorator, in main.py
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.