FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Emit correct sourcemap ranges for `JSXText` by liuxingbaoyu · Pull Request #15233 · babel/babel · GitHub

/ babel Public

fix: Emit correct sourcemap ranges for JSXText #15233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JLHwung merged 1 commit into from
Dec 5, 2022
Conversation 1 Commits 1 Checks 0 Files changed
Merged

fix: Emit correct sourcemap ranges for JSXText #15233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .js  (1) .json  (2) .mjs  (1) .ts  (1) All 4 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
      • input.js
      • options.json
      • output.mjs
      • source-map.json
11 changes: 11 additions & 0 deletions packages/babel-plugin-transform-react-jsx/test/fixtures/sourcemaps/JSXText/input.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import React from 'react';

export default function App() {
return (
<div className="App">
<h1>Welcome to my application!</h1>
This is my app!
<strong>MINE.</strong>
</div>
)
}
5 changes: 5 additions & 0 deletions packages/babel-plugin-transform-react-jsx/test/fixtures/sourcemaps/JSXText/options.json
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"sourceType": "module",
"plugins": [["transform-react-jsx", { "runtime": "classic" }]],
"sourceMap": true
}
6 changes: 6 additions & 0 deletions packages/babel-plugin-transform-react-jsx/test/fixtures/sourcemaps/JSXText/output.mjs
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import React from 'react';
export default function App() {
return /*#__PURE__*/React.createElement("div", {
className: "App"
}, /*#__PURE__*/React.createElement("h1", null, "Welcome to my application!"), "This is my app!", /*#__PURE__*/React.createElement("strong", null, "MINE."));
}
14 changes: 14 additions & 0 deletions packages/babel-plugin-transform-react-jsx/test/fixtures/sourcemaps/JSXText/source-map.json
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"version": 3,
"names": [
"React",
"App"
],
"sources": [
"sourcemaps/JSXText/input.js"
],
"sourcesContent": [
"import React from 'react';\n\nexport default function App() {\n return (\n <div className=\"App\">\n <h1>Welcome to my application!</h1>\n This is my app!\n <strong>MINE.</strong>\n </div>\n )\n}"
],
"mappings": "AAAA,OAAOA,KAAK,MAAM,OAAO;AAEzB,eAAe,SAASC,GAAG,GAAG;EAC5B,oBACE;IAAK,SAAS,EAAC;EAAK,gBAClB,gCAAI,4BAA0B,CAAK,mBAEnC,mDAAQ,OAAK,CAAS,CAClB;AAEV"
}
7 changes: 3 additions & 4 deletions packages/babel-types/src/utils/react/cleanJSXElementLiteralChild.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import { stringLiteral } from "../../builders/generated";
import type * as t from "../..";
import { inherits } from "../..";

export default function cleanJSXElementLiteralChild(
child: {
value: string;
},
child: t.JSXText,
args: Array<t.Node>,
) {
const lines = child.value.split(/\r\n|\n|\r/);
Expand Down Expand Up @@ -48,5 +47,5 @@ export default function cleanJSXElementLiteralChild(
}
}

if (str) args.push(stringLiteral(str));
if (str) args.push(inherits(stringLiteral(str), child));
}
Back | FazBrowse Home | New Git URL