FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Expose wether a module has TLA or not as `.extra.async` by nicolo-ribaudo · Pull Request #16480 · babel/babel · GitHub

/ babel Public

Expose wether a module has TLA or not as .extra.async - #16480

Merged
nicolo-ribaudo merged 7 commits into
babel:mainfrom
nicolo-ribaudo:parser-module-async
Jul 26, 2024
ConversationCommits (7)ChecksFiles changed
Merged

Expose wether a module has TLA or not as .extra.async#16480
nicolo-ribaudo merged 7 commits into
babel:mainfrom
nicolo-ribaudo:parser-module-async

Conversation

nicolo-ribaudo commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues? Fixes #16471
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The parser already has this info, and having to detect it by yourself is error prone (due to computed keys and decorators).

We can also use this to warn in the CJS transform when there is top-level await (in a follow-up).

nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser labels May 7, 2024

babel-bot commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57454

liuxingbaoyu commented May 7, 2024

Copy link
Copy Markdown
Member

Would it be better to just use topLevelAwait as the name?
Can we put hasTopLevelAwait in BaseParser together with sawUnambiguousESM, which would save a place, since 1 << 11 is already there :)

nicolo-ribaudo force-pushed the parser-module-async branch from 64070c7 to 0b4799c Compare May 7, 2024 07:57

nicolo-ribaudo commented May 7, 2024

Copy link
Copy Markdown
Member Author

Renamed to topLevelAwait. I prefer to keep this in .state.flags, because currently we have still 20 bits of space that are being "wasted" there :) If anything, I would move sawUnambiguousESM to there.

nicolo-ribaudo force-pushed the parser-module-async branch from 5e72f56 to d3dd293 Compare May 7, 2024 09:36
JLHwung approved these changes May 9, 2024
View reviewed changes

JLHwung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add a test case for module expressions if there aren't such test? The current implementation should already work.

nicolo-ribaudo added this to the v7.25.0 milestone May 14, 2024
nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label May 16, 2024
nicolo-ribaudo changed the title Expose wether a module has TLA or not as .extra.async Expose wether a module has TLA or not as .extra.async Jul 26, 2024
nicolo-ribaudo merged commit 5dc3b44 into babel:main Jul 26, 2024
nicolo-ribaudo deleted the parser-module-async branch July 26, 2024 09:46
This was referenced Aug 16, 2024
Open
Open
ashly1111111 mentioned this pull request Aug 16, 2024
Open
nejidevelops mentioned this pull request Aug 16, 2024
Open
DevangPatelUK mentioned this pull request Aug 16, 2024
Open
nejidevelops mentioned this pull request Aug 16, 2024
Open
This was referenced Oct 5, 2024
Open
Open
Open
Open
Open
richyhoopd mentioned this pull request Oct 6, 2024
Open
This was referenced Oct 6, 2024
Open
Open
mdfkbtc mentioned this pull request Oct 6, 2024
Open
nejidevelops mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 8, 2024
Open
Open
Open
paulineribeyre mentioned this pull request Oct 17, 2024
Closed
This was referenced Oct 24, 2024
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
This was referenced Oct 25, 2024
Open
Open
DevangPatelUK mentioned this pull request Oct 25, 2024
Open
snyk-io Bot mentioned this pull request Oct 26, 2024
Open
nejidevelops mentioned this pull request Oct 26, 2024
Open
richyhoopd mentioned this pull request Oct 26, 2024
Open
github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 26, 2024
github-actions Bot locked as resolved and limited conversation to collaborators Oct 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

JLHwung JLHwung approved these changes
liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release

Projects

None yet

Milestone

v7.25.0

Development

Successfully merging this pull request may close these issues.

[parser] Expose somehing like program.extra.async to easily know if a module uses top-level await

4 participants

Back | FazBrowse Home | New Git URL