fix: do not add .value: undefined to regexp literals - #16490
Merged
nicolo-ribaudo merged 1 commit intoJun 6, 2024
Merged
nicolo-ribaudo merged 1 commit into
nicolo-ribaudo merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
liuxingbaoyu
commented
May 13, 2024
Comment thread
packages/babel-parser/src/parser/expression.ts
| "RegExpLiteral", | ||
| ); | ||
| const node = this.startNode<N.RegExpLiteral>(); | ||
| this.addExtra(node, "raw", this.input.slice(node.start, this.state.end)); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This may also be removed (probably Babel 8)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I would keep it just for consistency with other literals
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56883 |
Sorry, something went wrong.
nicolo-ribaudo
approved these changes
May 14, 2024
JLHwung
approved these changes
Jun 5, 2024
This was referenced Aug 1, 2024
This was referenced Aug 1, 2024
This was referenced Aug 1, 2024
This was referenced Sep 3, 2024
This was referenced Sep 4, 2024
This was referenced Sep 5, 2024
This was referenced Sep 5, 2024
This was referenced Sep 6, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried representing undefined as null in output.json, but that would cause changes for 5000+ tests.