Generate helper metadata at build time - #16501
Merged
nicolo-ribaudo merged 19 commits intoMay 22, 2024
Merged
nicolo-ribaudo merged 19 commits into
nicolo-ribaudo merged 19 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57012 |
Sorry, something went wrong.
nicolo-ribaudo
force-pushed
the
static-helper-metata
branch
from
17a94db to
7883619
Compare
May 17, 2024 11:06
liuxingbaoyu
approved these changes
May 17, 2024
liuxingbaoyu
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Great! I like this!
Sorry, something went wrong.
nicolo-ribaudo
force-pushed
the
static-helper-metata
branch
from
0ca190e to
0c29d67
Compare
May 17, 2024 11:36
nicolo-ribaudo
force-pushed
the
static-helper-metata
branch
2 times, most recently
from
c95ee9a to
fc45887
Compare
May 18, 2024 12:38
nicolo-ribaudo
marked this pull request as ready for review
May 19, 2024 12:17
nicolo-ribaudo
force-pushed
the
static-helper-metata
branch
from
6f9b0fc to
168c0d2
Compare
May 20, 2024 10:34
nicolo-ribaudo
commented
May 20, 2024
Comment thread
packages/babel-helpers/src/helpers/OverloadYield.js
| this.k = kind; | ||
| } | ||
|
|
||
| export { _OverloadYield as default }; |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Support for this is needed in #16510
Sorry, something went wrong.
This was referenced Aug 19, 2024
This was referenced Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to:
This PR reduces the time needed to process a single helper by half (allHelpersNames.map(name => this.addHelper(name)); takes 100ms rather than 190ms on my machine)