Do not use strict mode in TS declare - #16567
Merged
nicolo-ribaudo merged 2 commits intoJun 10, 2024
Merged
nicolo-ribaudo merged 2 commits into
nicolo-ribaudo merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57162 |
Sorry, something went wrong.
Comment thread
packages/babel-parser/src/plugins/typescript/index.ts
Outdated
| ) { | ||
| let oldStrict; | ||
| if (this.state.isAmbientContext && this.state.strict) { | ||
| oldStrict = this.state.strict; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| oldStrict = this.state.strict; | |
| oldStrict = true; |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Or can we change the strictness when entering the ambient context, rather than when checking the identifier?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Or can we change the strictness when entering the ambient context, rather than when checking the identifier?
Sorry, something went wrong.
nicolo-ribaudo
approved these changes
Jun 8, 2024
JLHwung
approved these changes
Jun 10, 2024
This was referenced Aug 1, 2024
This was referenced Aug 1, 2024
This was referenced Aug 1, 2024
This was referenced Sep 9, 2024
This was referenced Sep 9, 2024
Open
This was referenced Sep 9, 2024
[Snyk] Upgrade: , , chai, mocha-jsdom, mocha-multi
tiff-es/fewpjs-acting-on-events-dc-web-091619#218
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if it would be better to modify packages\babel-parser\src\parser\lval.ts directly, that would be faster and simpler.