FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix printing of comments in `await using` by nicolo-ribaudo · Pull Request #16626 · babel/babel · GitHub

/ babel Public

Fix printing of comments in await using - #16626

Merged
nicolo-ribaudo merged 1 commit into
babel:mainfrom
nicolo-ribaudo:await-using-inner-comments
Jul 10, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Fix printing of comments in await using#16626
nicolo-ribaudo merged 1 commit into
babel:mainfrom
nicolo-ribaudo:await-using-inner-comments

Conversation

nicolo-ribaudo commented Jul 10, 2024

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

babel-bot commented Jul 10, 2024

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57295

JLHwung approved these changes Jul 10, 2024
View reviewed changes

JLHwung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch.

nicolo-ribaudo merged commit d4b08d0 into babel:main Jul 10, 2024
nicolo-ribaudo deleted the await-using-inner-comments branch July 10, 2024 14:26
davidjbradshaw mentioned this pull request Jul 19, 2024
Merged
richyhoopd mentioned this pull request Aug 1, 2024
Open
Exkaleburx mentioned this pull request Aug 1, 2024
Open
X-oss-byte mentioned this pull request Aug 1, 2024
Open
This was referenced Aug 1, 2024
Open
Open
Open
This was referenced Aug 1, 2024
Open
Merged
ashly1111111 mentioned this pull request Aug 1, 2024
Open
jamesleesaunders mentioned this pull request Aug 1, 2024
Closed
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
anbo-de mentioned this pull request Aug 2, 2024
Merged
This was referenced Aug 2, 2024
Open
Open
rawdaymohamed mentioned this pull request Sep 15, 2024
Open
AKJUS mentioned this pull request Sep 16, 2024
Open
bee22193 mentioned this pull request Sep 17, 2024
Open
AnushaSalian mentioned this pull request Sep 17, 2024
Open
vinit-aikido mentioned this pull request Sep 17, 2024
Open
Sonic269 mentioned this pull request Sep 17, 2024
Open
venkatarao-palaparthi mentioned this pull request Sep 17, 2024
Open
AKJUS mentioned this pull request Sep 17, 2024
Open
rawdaymohamed mentioned this pull request Sep 17, 2024
Open
karencapiiro mentioned this pull request Sep 17, 2024
Open
bee22193 mentioned this pull request Sep 18, 2024
Open
vinit-aikido mentioned this pull request Sep 18, 2024
Open
syofyanzuhad mentioned this pull request Sep 18, 2024
Open
AnushaSalian mentioned this pull request Sep 18, 2024
Open
Sonic269 mentioned this pull request Sep 18, 2024
Open
MrRio mentioned this pull request Sep 18, 2024
Closed
AnushaSalian mentioned this pull request Sep 19, 2024
Open
venkatarao-palaparthi mentioned this pull request Sep 19, 2024
Open
rawdaymohamed mentioned this pull request Sep 19, 2024
Open
venkatarao-palaparthi mentioned this pull request Sep 20, 2024
Open
rawdaymohamed mentioned this pull request Sep 20, 2024
Open
venkatarao-palaparthi mentioned this pull request Sep 21, 2024
Open
rawdaymohamed mentioned this pull request Sep 21, 2024
Open
This was referenced Sep 22, 2024
Open
Open
rawdaymohamed mentioned this pull request Sep 23, 2024
Open
anandgupta193 mentioned this pull request Sep 24, 2024
Open
anandgupta193 mentioned this pull request Oct 3, 2024
Open
github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 10, 2024
github-actions Bot locked as resolved and limited conversation to collaborators Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

JLHwung JLHwung approved these changes
liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Explicit Resource Management

Projects

None yet

Milestone

generator: preserveFormat

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL