Lazy top-level initializations for module transforms - #16629
Merged
nicolo-ribaudo merged 5 commits intoJul 12, 2024
Merged
nicolo-ribaudo merged 5 commits into
nicolo-ribaudo merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57327 |
Sorry, something went wrong.
nicolo-ribaudo
force-pushed
the
lazy-module-transforms
branch
from
c4c1df0 to
607b490
Compare
July 11, 2024 08:13
nicolo-ribaudo
approved these changes
Jul 12, 2024
nicolo-ribaudo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks! It's unfortunate that we cannot easily add a test for this, but hopefully once we release Babel 8 (as native ESM) this problem won't risk happening anymore.
Sorry, something went wrong.
JLHwung
approved these changes
Jul 12, 2024
This was referenced Aug 5, 2024
This was referenced Oct 4, 2024
Open
This was referenced Oct 5, 2024
Open
Open
This was referenced Oct 5, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a cyclic dependency between babel-helper-module-transforms and babel-core, which is not currently supported in jspm.io for running Babel when it is transpiled into ESM since CJS cycles behave differently to ESM cycles in allowing bindings defined before the require to be available.
With this minor refactoring in hoisting I've verified that this gets Babel to work correctly on jspm.io again.
There may be even be some minor top-level initialization performance benefits here as well in only initializing used features.