Move hoistVariables to Scope.prototype - #16644
Merged
nicolo-ribaudo merged 2 commits intoJul 17, 2024
Merged
nicolo-ribaudo merged 2 commits into
nicolo-ribaudo merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57387 |
Sorry, something went wrong.
JLHwung
approved these changes
Jul 15, 2024
liuxingbaoyu
approved these changes
Jul 15, 2024
4 tasks
nicolo-ribaudo
force-pushed
the
remove-cycles-2
branch
from
ac6609b to
ebfe88e
Compare
July 17, 2024 12:15
nicolo-ribaudo
added a commit
that referenced
this pull request
Jul 26, 2024
nicolo-ribaudo
added a commit
that referenced
this pull request
Jul 26, 2024
nicolo-ribaudo
added a commit
that referenced
this pull request
Jul 26, 2024
This was referenced Aug 16, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 5, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the same path as #16577, trying to remove type circular deps so that we can publish .d.ts definitions.
@babel/helper-hoist-variables works on NodePaths and is a dependency of @babel/traverse, so they will be always installed together. I moved it to Scope.prototype, since it's about scope handling.
Also, I noticed that we never actually set the kind parameter to anything other than "var", so I just removed it.