Move environment-visitor helper into @babel/traverse - #16649
Merged
nicolo-ribaudo merged 1 commit intoJul 17, 2024
Merged
nicolo-ribaudo merged 1 commit into
nicolo-ribaudo merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57369 |
Sorry, something went wrong.
4 tasks
nicolo-ribaudo
added a commit
that referenced
this pull request
Jul 26, 2024
nicolo-ribaudo
added a commit
that referenced
this pull request
Jul 26, 2024
rayhomie
reviewed
Jul 29, 2024
Comment thread
packages/babel-helper-remap-async-to-generator/src/index.ts
| ArrowFunctionExpression(path) { | ||
| path.skip(); | ||
| }, | ||
| const awaitVisitor = visitors.environmentVisitor<{ wrapAwait: t.Expression }>({ |
Copy link
Copy Markdown
There was a problem hiding this comment.
_traverse.visitors.environmentVisitor is not a function
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Hi, Yes, this PR cause an eslint issue in our codebase repo, this is the version we are on.
Not sure if maybe extensions we use are on latest babels, I have eslint extension installed on vs code as well.
Is there an issue opened or plans to fix this? Thanks!
Sorry, something went wrong.
1 task
This was referenced Aug 16, 2024
This was referenced Aug 17, 2024
This was referenced Oct 27, 2024
This was referenced Oct 27, 2024
This was referenced Oct 27, 2024
Open
This was referenced Oct 28, 2024
This was referenced Oct 29, 2024
This was referenced Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was landed in #16577 and reverted in #16647 because merged too soon. It has already been reviewed.