Move ensureFunctionName to NodePath.prototype - #16658
Merged
nicolo-ribaudo merged 3 commits intoJul 26, 2024
Merged
nicolo-ribaudo merged 3 commits into
nicolo-ribaudo merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
nicolo-ribaudo
force-pushed
the
remove-cycles-4
branch
from
51a2483 to
caddc1c
Compare
July 17, 2024 12:27
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57471 |
Sorry, something went wrong.
4 tasks
Comment thread
packages/babel-plugin-transform-classes/src/transformClass.ts
Outdated
liuxingbaoyu
approved these changes
Jul 25, 2024
nicolo-ribaudo
force-pushed
the
feat-7.25.0/remove-cycles
branch
2 times, most recently
from
bcac3c8 to
62b12b0
Compare
July 26, 2024 10:30
nicolo-ribaudo
force-pushed
the
remove-cycles-4
branch
from
3d8bbcc to
a075294
Compare
July 26, 2024 12:24
JLHwung
approved these changes
Jul 26, 2024
Copy link
Copy Markdown
|
Hello, because of this change we're seeing a breaking change: value.ensureFunctionName is not a function. Can you please let us know how we fix this? |
Sorry, something went wrong.
1 task
This was referenced Aug 16, 2024
This was referenced Oct 29, 2024
This was referenced Oct 30, 2024
This was referenced Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be the last non-peerDependencies cycle between packages :)