Disallow decorators on abstract/declare fields - #17949
Merged
nicolo-ribaudo merged 3 commits intoMay 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61428 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
commit: 7469dd6 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@fisker About the prettier failure, do you think you could change the test to either:
|
Sorry, something went wrong.
JLHwung
approved these changes
Apr 24, 2026
liuxingbaoyu
approved these changes
Apr 24, 2026
liuxingbaoyu
approved these changes
Apr 25, 2026
nicolo-ribaudo
force-pushed
the
stricter-decorators
branch
from
e5bf5cd to
d18ef0d
Compare
May 1, 2026 15:48
nicolo-ribaudo
force-pushed
the
stricter-decorators
branch
from
d18ef0d to
7469dd6
Compare
May 1, 2026 16:01
Copy link
Copy Markdown
Member
Author
|
@fisker Actually, prettier should probably just ignore the DecoratorAbstractMethod error code (it's how I'm patching Prettier in our tests) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.